Skip to content

Commit

Permalink
fix: Python2 build
Browse files Browse the repository at this point in the history
Manylinux image dropped Python2 support in version
quay.io/pypamanylinux2010_x86_64:2021-02-07-7816579
The release action uses the latest manylinux image, thus it lost Python2
compatibility, too.

Solution:
[fork](https://github.com/user2589/python-wheels-manylinux-build) the
release github action, using the latest manylinux release before Py2
support was dropped
(quay.io/pypa/manylinux2010_x86_64:2021-02-06-3d322a5)
  • Loading branch information
user2589 committed Jun 9, 2021
1 parent 35d4ca9 commit d65fb40
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
- name: Build manylinux package
# manylinux2014_x86_64 doesn't support Python 2,
# use the default manylinux2010_x86_64
uses: RalfG/python-wheels-manylinux-build@v0.3.3
uses: user2589/python-wheels-manylinux-build@master
with:
python-versions: 'cp36-cp36m'
python-versions: 'cp27-cp27mu cp36-cp36m'
build-requirements: 'cython setuptools>=18.0'
system-packages: 'bzip2-devel zlib-devel'

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build:
# https://github.com/RalfG/python-wheels-manylinux-build
.PHONY: build_manylinux
build_manylinux:
docker run --rm -e PLAT=manylinux2010_x86_64 -v `pwd`:/github/workspace/ quay.io/pypa/manylinux2010_x86_64 "cp27-cp27m cp36-cp36m" "cython setuptools>=18.0" "bzip2-devel zlib-devel"
docker run --rm -e PLAT=manylinux2010_x86_64 -v `pwd`:/github/workspace/ python-wheels-manylinux-build "cp27-cp27m cp36-cp36m" "cython setuptools>=18.0" "bzip2-devel zlib-devel"

.PHONY: test
test:
Expand Down
6 changes: 3 additions & 3 deletions docs/contribute.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ a special Docker image, and is automated via GitHub action.
To build package locally,

#. clone the corresponding GitHub action repository,
`git clone git@github.com:RalfG/python-wheels-manylinux-build.git`,
#. check out the desired tag if necessary, e.g. `git checkout v0.3.3`
#. build Docker image: `docker build -t manylinux2010 .`
`git clone git@github.com:user2589/python-wheels-manylinux-build.git`,
#. check out the desired tag if necessary, e.g. `git checkout v0.3.4`
#. build Docker image: `docker build -t ython-wheels-manylinux-build .`
#. run the image: `make build_manylinux`


Expand Down

0 comments on commit d65fb40

Please sign in to comment.