-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
010: thread spec #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the mermaids. 🧜♀️
The document needs a little bit of structure, with abstract, specification, etc. Also we need to address those TODOs before merging. And I need to give it a read to make sure it's more prescriptive (telling readers what they should do to implement this SIP) than educational (giving readers a tour through threads world), with some MUSTs and SHOULDs.
@staltz I want to do the minimal additional work to get this merged. TODOs:
Prescriptive vs. educational, yes keen to see that done. Given I don't want to do much more work on this, but we need it written down somewhere, would you be down to pair on this to get it done? |
I'm your inverse, I feel less motivated when I'm pairing to get things done. I suggest we just relax the deadlines with this PR. You (or me) can come back to it some time in the future and finish the TODOs. |
for what it's worth, thread forks should probably be a separate spec anyways. |
A wild @ahdinosaur appears! Hi <3 @staltz can we just merge this. It's better than nothing, and not having it in |
Nope! Let's please not push documents that have TODOs in them as official specification. If someone really wants to read something in progress, they can just open the "Pull Requests" tab and browse this. It would also go against the REVIEWING.md which wasn't written in vain, so please don't merge things that are work in progress. |
I want to remove forks from this spec, and merge it |
DONE - removed forks |
I'll take a look, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super sweet SIP. I like how it's complete: specifies msg schemas, specifies how the tangles works, how channels works, how content warnings work etc.
I have a few suggestions to fix before merging, nothing that requires you to write anything yourself, since I put the code suggestions inline. Mostly, there is some ambiguity with the notation [X]
which could confuse some readers. That's the most important thing to fix.
Then, there's just a suggestion to relax some MUST to SHOULD.
That's all I have, and then feel free to merge.
Co-authored-by: André Staltz <andre@staltz.com>
Co-authored-by: André Staltz <andre@staltz.com>
merge squashed! |
No description provided.