Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text support #30

Closed
wants to merge 1 commit into from
Closed

Conversation

raykov
Copy link

@raykov raykov commented Oct 2, 2021

No description provided.

@raykov raykov force-pushed the NOREF-add-Text-support branch from 3cbe87c to 38359c2 Compare October 2, 2021 16:29
@raykov raykov closed this Oct 2, 2021
@raykov raykov deleted the NOREF-add-Text-support branch October 2, 2021 16:30
@srwiley
Copy link
Owner

srwiley commented Oct 4, 2021

Raykov, I will definitely look into this. Is there are reason you deleted the pull request? Text features can be basic, rather than doing the full SVG implementation, which is quite elaborate. That is why we call it oksvg.
Also it would be good to put these new features into a separate file so that the core files do not become too large and generic. Finally, adding testing makes it much easier for me to accept a pull request. This can be done by adding a few test files into the example testing folder.
Thank you for your efforts.

@juburr juburr mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants