Fixed more bugs and added comments #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs in utils.h in functions used for read/writing words to array buffers of bits, substantially rewriting some of the functions to make them more obvious. This solves the raw2digi run time errors about strip number exceeding 1016.
Added comments to code to clarify it. Changed some function and variable names to make their purpose clearer.
Fixed bug in Phase2TrackerFEDBuffer::setFrontendStatus(), which sets the 72 status bits (which indicate which input channels of each DTC are active). The bits were in the wrong order compared to the read function frontendStatus().
Some CPU optimisation, passing big objects to functions via reference where possible.
Added comment "IAN blah blah" where anything looks weird, and needs investigating further.
Ran scram b code-format
Instructions to check out this code:
a) git cms-checkout-topic -u tomalin:ianFixMoreBugs
b) git cms-addpkg CalibTracker/SiStripESProducers/
c) git cms-addpkg CondCore/SiStripPlugins/