sort tags in consistent order #53
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucpr
force-pushed
the
consistently-sort-tags
branch
from
0cfffd0 to
40424ea
Compare
ucpr
force-pushed
the
consistently-sort-tags
branch
from
40424ea to
d113be1
Compare
ucpr
commented
Aug 4, 2024
| @@ -2,6 +2,6 @@ package main | |||
|
|
|||
| type Simple struct { | |||
| Single string `json:"key,option" sql:"-,omitempty"` | |||
| Multiple *string `json:"ke,op" xml:"-,omitempty"` | |||
| Multiple *string `json:"ke,op" xml:"-,omitempty" bson:"ke,op" sql:"ke,op"` | |||
There was a problem hiding this comment.
Only tags generated by protoc-gen-gotag are sorted in ascending order.
ldepaulatrac
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix to sort the generated tags in a consistent order.
#51