Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct coverage when a file with the same name exists in the archive. #50

Closed
ghost opened this issue Aug 19, 2019 · 5 comments
Closed
Assignees
Labels
new-feature New feature or request

Comments

@ghost
Copy link

ghost commented Aug 19, 2019

When adding a file to compression, a file with the same name exists in the archive. an override option should be provided.

@srikanth-lingala srikanth-lingala added the new-feature New feature or request label Aug 21, 2019
@srikanth-lingala srikanth-lingala self-assigned this Aug 21, 2019
@srikanth-lingala
Copy link
Owner

Will include this feature in the next release

@ghost
Copy link
Author

ghost commented Aug 23, 2019

将在下一版本中包含此功能

If a file with the same name also exists in the folder, it is best to overwrite it as well. And also, I hope you can specify compression to a path instead of the root directory.

Thank you for your work.

@ghost
Copy link
Author

ghost commented Aug 24, 2019

image

Compression will crash when a file with the same name exists in the zip!

@LeeYoung624
Copy link
Contributor

LeeYoung624 commented Sep 7, 2019

Hey @isMeiying

Compression will crash when a file with the same name exists in the zip!

Could you please provide your test code and test files? This exception seems not likely caused by same name files. More detail information could help me find out what's going on here.

@srikanth-lingala
Copy link
Owner

ZipParameters.overrideExistingFilesInZip feature added in v2.1.3 released today.

Regarding the ZipException, I was unable to reproduce that error both on windows and a mac. As LeeYoung pointed out, please provide more info (code, zip sample, etc) for us to investigate, and please open a new issue if you have those details. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants