Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do no pass under windows #291

Closed
Dunemaster opened this issue Feb 28, 2021 · 3 comments
Closed

Tests do no pass under windows #291

Dunemaster opened this issue Feb 28, 2021 · 3 comments
Assignees
@srikanth-lingala
Labels
improvement resolved

Comments

@Dunemaster
Copy link
Contributor

FileUtilsTest.testGetRelativeFileWithRootFolderNameInZip
FileUtilsTest.testGetRelativeFileWithDifferentFileNameInZipAndRootFolderNameAndDefaultFolderPath
FileUtilsTest.testGetRelativeFileWithRootFolderNameInZipWithFileSeparator
FileUtilsTest.testGetRelativeFileWithRootFolderNameInZipWithSeparatorsInName
FileUtilsTest.testGetRelativeFileWithDifferentFileNameInZipAndRootFolderName

org.junit.ComparisonFailure:
Expected :"rootfolder\somefile.txt"
Actual :"rootfolder/somefile.txt"

image
@IkoRein
Copy link

IkoRein commented Mar 7, 2021

Hit this too just now.

The reason it fails, is because e.g. on the
testGetRelativeFileWithRootFolderNameInZip
the pathSeparator is set to FILE_SEPARATOR. Replacing it with ZIP_FILE_SEPARATOR in all those 5 failing test cases makes the tests pass. And the compiled package works on Windows.

Cheers

srikanth-lingala added a commit that referenced this issue Apr 6, 2021
@srikanth-lingala
#291 Fix tests failing on Windows
9fe0987
@srikanth-lingala
Copy link
Owner

Issue fixed. Commit

@srikanth-lingala srikanth-lingala self-assigned this Apr 6, 2021
@srikanth-lingala
Copy link
Owner

Fixed in v2.8.0 released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
improvement resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srikanth-lingala @Dunemaster @IkoRein