Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit (git-hooks) #41

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Add pre-commit (git-hooks) #41

merged 9 commits into from
Dec 20, 2024

Conversation

anntnzrb
Copy link
Contributor

@anntnzrb anntnzrb commented Dec 19, 2024

An attempt to mirror haskell-template's latest (and greatest) changes. I wonder if treesitter treefmt should be dropped here as well?

The structure remains, however the filename nix/modules/formatting.nix is not really accurate anymore (if treesitter treefmt was to be removed).

I only added some hooks as a base. clippy was dropped as it was being annoying.

Oh, also some .envrc tweaks as well.

@anntnzrb
Copy link
Contributor Author

ff5a0b3 - added some docs

Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Can you remove treefmt entirely?

srid/haskell-template@85b7437

I wonder if treesitter should be dropped here as well?

Can you elaborate?

@anntnzrb
Copy link
Contributor Author

I wonder if treesitter should be dropped here as well?

Can you elaborate?

😵‍💫 I meant treefmt! It is no longer. ^

Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge from master to resolve the conflicts?

nix/modules/formatting.nix Outdated Show resolved Hide resolved
nix/modules/formatting.nix Outdated Show resolved Hide resolved
@anntnzrb
Copy link
Contributor Author

Can you merge from master to resolve the conflicts?

It's done.

@srid srid merged commit 9b0d778 into srid:master Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants