Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-ws to disable websocket handling in live server #161

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

srid
Copy link
Owner

@srid srid commented Dec 11, 2023

Resolves #159

  • Initial impl
  • Test in emanote
  • Update docs & changelog

Comment on lines +33 to +35
newtype NoWebSocket = NoWebSocket {unNoWebSocket :: Bool}
deriving newtype (Eq, Show)
deriving stock (Generic)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd much prefer to propagate EmaWebSocketOptions r to the CLI.Action type ... but the r parameter gets in the way.

@srid srid marked this pull request as ready for review February 9, 2024 12:54
@srid srid merged commit 33e9877 into master Feb 9, 2024
1 check passed
@srid srid deleted the no-ws branch February 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a plain server mode
1 participant