fix: issue in spawning scrcpy after migrating to list based command e…

…xecution Fixes #305
srevinsaju · Apr 21, 2022 · 97c0bcd · 97c0bcd
1 parent eb8398f
commit 97c0bcd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/guiscrcpy/launcher.py b/guiscrcpy/launcher.py
@@ -1161,9 +1161,13 @@ def start_act(self):
         if self.cmx is not None:
             self.config["cmx"] = " ".join(map(str, self.cmx))
 
-        arguments_scrcpy = "{} {} {}".format(
-            self.options, self.config["extra"], self.config["cmx"]
-        )
+        arguments_scrcpy = [
+            i
+            for i in "{} {} {}".format(
+                self.options, self.config["extra"], self.config["cmx"]
+            ).split()
+            if i != ""
+        ]
         progress = self.progress(progress)
 
         # ====================================================================

diff --git a/guiscrcpy/lib/bridge/scrcpy.py b/guiscrcpy/lib/bridge/scrcpy.py
@@ -17,7 +17,7 @@ def post_init(self):
 
     def start(self, args, stdout=PIPE, stderr=PIPE):
         proc = open_process(
-            [self.path, args],
+            [self.path] + args,
             stdout=stdout,
             stderr=stderr,
         )