This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Add support for VIEWs in SHOW TABLES statements #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
golangcibot
reviewed
Oct 29, 2019
agarciamontoro
force-pushed
the
feature.views.show
branch
from
522dadf to
1220b98
Compare
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
juanjux
reviewed
Oct 29, 2019
juanjux
reviewed
Oct 29, 2019
| return err | ||
| } | ||
|
|
||
| if len(newItem) < 1 || len(newItem) > 2 { |
There was a problem hiding this comment.
nit: Personally I think if len(newItem) != 1 || len(newItem) != 2 would be clearer (also maybe a few nanoseconds faster, or not, depending on how Go optimizes).
There was a problem hiding this comment.
Hmm, why do you think it is clearer? I see the interval (1,2) in the other case much more clear. But I guess that it only comes down to personal opinions. Although it would be cool to actually measure which one is faster!
juanjux
reviewed
Oct 29, 2019
juanjux
approved these changes
Oct 29, 2019
Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after #860
This PR:
ShowTablesnode.ShowTables(that relied on the expected order) to sort the rows after they are received.