-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: very basic REPL implementation #97
Conversation
Current coverage is 61.31% (diff: 100%)
|
for { | ||
fmt.Print("!> ") | ||
|
||
s.Scan() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check return value
continue | ||
} | ||
|
||
err = c.printQuery(schema, rowIter, "pretty") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single line?
return err | ||
} | ||
|
||
fmt.Print("\n gitQL REPL\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a ``` string
fmt.Printf("ERROR: %v\n\n", err) | ||
} | ||
|
||
func ScanQueries(data []byte, atEOF bool) (int, []byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private?
Basic REPL that only supports query executions.
Basic REPL that only supports query executions.