Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: very basic REPL implementation #97

Merged
merged 2 commits into from
Jan 13, 2017
Merged

cmd: very basic REPL implementation #97

merged 2 commits into from
Jan 13, 2017

Conversation

ajnavarro
Copy link
Contributor

Basic REPL that only supports query executions.

@codecov-io
Copy link

codecov-io commented Jan 13, 2017

Current coverage is 61.31% (diff: 100%)

No coverage report found for master at 2bbc3bd.

Powered by Codecov. Last update 2bbc3bd...8ae4448

@ajnavarro ajnavarro requested a review from smola January 13, 2017 16:26
for {
fmt.Print("!> ")

s.Scan()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check return value

continue
}

err = c.printQuery(schema, rowIter, "pretty")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single line?

return err
}

fmt.Print("\n gitQL REPL\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a ``` string

fmt.Printf("ERROR: %v\n\n", err)
}

func ScanQueries(data []byte, atEOF bool) (int, []byte, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

Basic REPL that only supports query executions.
@smola smola merged commit 761ba5e into src-d:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants