Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom bblfsh build #714

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

ajnavarro
Copy link
Contributor

This is causing the following error on make dependencies after bblfsh sdk update:

11:50 $ make dependencies
cd vendor/gopkg.in/bblfsh/client-go.v3 && make dependencies
make[1]: Entering directory 'work/src/github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/client-go.v3'
go get -v -t -t ./...
github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/client-go.v3/cmd/bblfsh-cli
# github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/client-go.v3/cmd/bblfsh-cli
cmd/bblfsh-cli/main.go:92:30: cannot use ast (type "github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/sdk.v2/uast/nodes".Node) as type "gopkg.in/bblfsh/sdk.v2/uast/nodes".Node in argument to uastyml.Marshal:
	"github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/sdk.v2/uast/nodes".Node does not implement "gopkg.in/bblfsh/sdk.v2/uast/nodes".Node (wrong type for Clone method)
		have Clone() "github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/sdk.v2/uast/nodes".Node
		want Clone() "gopkg.in/bblfsh/sdk.v2/uast/nodes".Node
.ci/Makefile.main:125: recipe for target 'dependencies' failed
make[1]: *** [dependencies] Error 2
make[1]: Leaving directory 'work/src/github.com/src-d/gitbase/vendor/gopkg.in/bblfsh/client-go.v3'
Makefile:21: recipe for target 'bblfsh-client' failed
make: *** [bblfsh-client] Error 2

Signed-off-by: Antonio Jesus Navarro Perez antnavper@gmail.com

Signed-off-by: Antonio Jesus Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro merged commit 4552cb4 into src-d:master Feb 28, 2019
@ajnavarro ajnavarro deleted the remove-bblfsh-custom-make branch February 28, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants