Add url & opengraph card previews #720
Open
+1,950
−321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
force-pushed
the
feat/url-preview
branch
from
5ac781a to
467e247
Compare
tarkah
force-pushed
the
feat/url-preview
branch
2 times, most recently
from
5152d48 to
b914b53
Compare
This is more stable since due to chat history messages can be overridden and their received time will update, but server time is the same. I noticed a regression in highlight buffer where certain messages weren't triggering a scroll to message because of this, since the highlight message retains the oldest received at. Changing this fixed the regression since their server times remain the same.
tarkah
force-pushed
the
feat/url-preview
branch
from
b914b53 to
a276c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@casperstorm please work your magic on preview / card UI in
scroll_view@andymandias can you help test the scrollable? I've landed on a new implementation that allows us to be "sticky" to the top of the viewport when it's unlocked (not anchored to the bottom to auto-scroll w/ new messages). This means that when images load or older chat history messages load, the scrollable should not shift out from under us and provides a very pleasant experience. I believe I've been able to improve on / fix some of the chat history bugs related to scrolling / infinite scrolling.