Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra tabs in case content.tabs.link is enabled, get switched to another tab while scrolling. #7232

Closed
4 tasks done
AdityaGarg8 opened this issue Jun 1, 2024 · 7 comments
Closed
4 tasks done
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@AdityaGarg8
Copy link

Context

No response

Bug description

I have created a webpage with content.tabs.link enabled. Link: https://adityagarg8.github.io/wiki/guides/wifi-bluetooth/. In this webpage you can see, there are 2 sections, On macOS and On Linux. On macOS section has tabs by the name of Method 1, Method 2 and Method 3. On Linux section also has these 3 tabs + 1 additional Method 4 tab. If I choose the method 4 tab, and start scrolling, it resets to the tab which has been selected in the On macOS section.

Related links

Reproduction

I am unable to make a zip file since I am getting the error: The "info" plugin is not installed. So I am sending the repository as a zip.
wiki.zip

Steps to reproduce

  1. Open https://adityagarg8.github.io/wiki/guides/wifi-bluetooth/
  2. Go to the On Linux section there
  3. Choose the tab having Method 4
  4. Scroll the page, the tab switches to some other tab

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. Please provide a minimal reproduction, not your entire repository. The error might be hiding in your customizations, so we need to be sure it originates from our code. Using the info plugin is absolutely mandatory. Make sure to upgrade Material for MkDocs as well. We might have fixed it in a subsequent version. Thus, please follow our bug reporting guide carefully and provide a clean and minimal reproduction that showcases the issue.

We can reopen this issue once you provide the reproduction.

@squidfunk squidfunk added the needs reproduction Issue lacks a minimal reproduction .zip file label Jun 2, 2024
@AdityaGarg8
Copy link
Author

Hello @squidfunk

I managed to create a minimal reproduction zip. Apparently, info plugin wasn't working in macOS, but I succeeded on Linux.
9.5.25-content-tabs-link-bug.zip

@AdityaGarg8
Copy link
Author

Steps to reproduce

  1. Open wifi-bluetooth guide in the docs folder in the zip.
  2. Go to the On Linux section there
  3. Choose the tab having Method 4
  4. Scroll the page, the tab switches to some other tab

@squidfunk
Copy link
Owner

Confirmed, thanks for the reproduction. I'll look into it.

@squidfunk squidfunk added bug Issue reports a bug and removed needs reproduction Issue lacks a minimal reproduction .zip file labels Jun 2, 2024
@squidfunk squidfunk reopened this Jun 2, 2024
@squidfunk
Copy link
Owner

Fixed in 1cc45d5. It was related to the changes introduced in #7232. to compute the indicator for nested content tabs, which led to each content tab container being remounted on visibility. The applied changes should mitigate both issues.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Jun 6, 2024
@AdityaGarg8
Copy link
Author

Fixed in 1cc45d5. It was related to the changes introduced in #7232. to compute the indicator for nested content tabs, which led to each content tab container being remounted on visibility. The applied changes should mitigate both issues.

Thanks. It works now.

@squidfunk
Copy link
Owner

Released as part of 9.5.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants