Kotlin generated message's contructor respect fields declaration order #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
force-pushed
the
bquenaudon.2021-06-22.respectdeclarationorderinconstructor
branch
from
3c8b3e8 to
5061ac8
Compare
oldergod
deleted the
bquenaudon.2021-06-22.respectdeclarationorderinconstructor
branch
MehdiAghajani
pushed a commit
to MehdiAghajani/wire
that referenced
this pull request
Dec 26, 2021
square#1997) * regenerated tests * regenerated tests * Kotlin generated message's contructor respect fields declaration order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hesitated using a sealed class something like
sealed class FieldOrOneOfbut didn't; could be convinced otherwise...Split in 2 commits.
Here is the before after of how fields were ordered.
Before
fields
extensions
flatOneOfs
boxedOneOfs
After
(everything).sortBy { it.location.line }