Restrict stdlib usage to 1.3. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
requested review from
jamesmosley55,
pyricau and
a team
as code owners
This reverts the changes to stdlib call sites made in 0a0f4d2. This change ensures the library is still consumable from projects built with kotlin 1.3.
zach-klippenstein
force-pushed
the
zachklipp/restrict-stdlib-1.3
branch
from
7cd7da1
to
0075651
Compare
|
All this config is a lot more configuration to maintain than just… not upgrading to 1.4 yet. I think I will close this and just revert #45 instead. |
|
Superseded by #51. |
|
Re-opening since #51 breaks the Compose sample. |
pyricau
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes to stdlib call sites made in 0a0f4d2.
This change ensures the library is still consumable from projects built with kotlin 1.3.
Some discussion on Kotlin Slack about this, using Kt 1.4 with
apiVersion = "1.3"isn't enough, and using Kt 1.3 settinglanguageLevel = "1.4"won't work either.