Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Data race due to consul dependencies #832

Open
mpuncel opened this issue May 3, 2017 · 0 comments
Open

Data race due to consul dependencies #832

mpuncel opened this issue May 3, 2017 · 0 comments

Comments

@mpuncel
Copy link
Collaborator

mpuncel commented May 3, 2017 •
edited
Loading 

==================
WARNING: DATA RACE
Read at 0x00c4201726c8 by goroutine 98:
  github.com/square/p2/vendor/github.com/hashicorp/consul/consul.(*Server).leaderLoop()
      /home/travis/gopath/src/github.com/square/p2/vendor/github.com/hashicorp/consul/consul/leader.go:60 +0x12f
Previous write at 0x00c4201726c8 by goroutine 30:
  github.com/square/p2/vendor/github.com/hashicorp/consul/consul.NewServer()
      /home/travis/gopath/src/github.com/square/p2/vendor/github.com/hashicorp/consul/consul/server.go:268 +0x146e
  github.com/square/p2/vendor/github.com/hashicorp/consul/command/agent.(*Agent).setupServer()
      /home/travis/gopath/src/github.com/square/p2/vendor/github.com/hashicorp/consul/command/agent/agent.go:406 +0x162
  github.com/square/p2/vendor/github.com/hashicorp/consul/command/agent.Create()
      /home/travis/gopath/src/github.com/square/p2/vendor/github.com/hashicorp/consul/command/agent/agent.go:203 +0x1010
  github.com/square/p2/pkg/store/consul/consulutil.NewFixture()
      /home/travis/gopath/src/github.com/square/p2/pkg/store/consul/consulutil/consultest.go:80 +0x4eb
  github.com/square/p2/pkg/store/consul.NewConsulTestFixture()
      /home/travis/gopath/src/github.com/square/p2/pkg/store/consul/fixtures_test.go:20 +0x6a
  github.com/square/p2/pkg/store/consul.TestGetHealthNoEntry()
      /home/travis/gopath/src/github.com/square/p2/pkg/store/consul/kv_test.go:15 +0x66
  testing.tRunner()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:610 +0xc9
Goroutine 98 (running) created at:
  github.com/square/p2/vendor/github.com/hashicorp/consul/consul.(*Server).monitorLeadership()
      /home/travis/gopath/src/github.com/square/p2/vendor/github.com/hashicorp/consul/consul/leader.go:39 +0x206
Goroutine 30 (running) created at:
  testing.(*T).Run()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:646 +0x52f
  testing.RunTests.func1()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:793 +0xb9
  testing.tRunner()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:610 +0xc9
  testing.RunTests()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:799 +0x4ba
  testing.(*M).Run()
      /home/travis/.gimme/versions/go1.7.4.linux.amd64/src/testing/testing.go:743 +0x12f
  main.main()
      github.com/square/p2/pkg/store/consul/_test/_testmain.go:92 +0x1b8
mpuncel added a commit to mpuncel/p2 that referenced this issue May 3, 2017
@mpuncel
disable race testing with build flags for known races
0c6f45a 
See square#832
mpuncel added a commit to mpuncel/p2 that referenced this issue May 3, 2017
@mpuncel
disable race testing with build flags for known races
19536ba 
See square#832
mpuncel added a commit to mpuncel/p2 that referenced this issue May 3, 2017
@mpuncel
disable race testing with build flags for known races
298bd17 
See square#832
petertseng pushed a commit to petertseng/p2 that referenced this issue Jun 7, 2017
travis: Run once with the race detector and once without.
a97f435 
We're working around square#832

We're refining the method used in square#831
It becomes harder to maintain the list of packages that will get
excluded from the race detector (and thus must be rerun without it), so
we will just run all tests without and all tests with.

Since we desire not to slow down the tests by running them twice, we
hope to mitigate the slowdown by running the two in parallel.
@petertseng petertseng mentioned this issue Jun 7, 2017
Merged
petertseng pushed a commit to petertseng/p2 that referenced this issue Jun 7, 2017
travis: Run once with the race detector and once without
b97e0e2 
We're working around square#832

We're refining the method used in square#831
It becomes harder to maintain the list of packages that will get
excluded from the race detector (and thus must be rerun without it), so
we will just run all tests without and all tests with.

Since we desire not to slow down the tests by running them twice, we
hope to mitigate the slowdown by running the two in parallel.
petertseng added a commit that referenced this issue Jun 7, 2017
@petertseng
travis: Run once with the race detector and once without (#867)
0e25d8e 
We're working around #832

We're refining the method used in #831
It becomes harder to maintain the list of packages that will get
excluded from the race detector (and thus must be rerun without it), so
we will just run all tests without and all tests with.

Since we desire not to slow down the tests by running them twice, we
hope to mitigate the slowdown by running the two in parallel.
drcapulet pushed a commit to drcapulet/p2 that referenced this issue May 17, 2018
@mpuncel @drcapulet
disable race testing with build flags for known races
a2bdd36 
See square#832
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpuncel