Expand 103 handling to other non-specific 1XX messages. #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @reschke |
102 doesn't specify any specific changes to timeout handling. |
reschke
reviewed
Jan 4, 2023
|
|
||
| // Early Hints (103) but not supported yet in OkHttp | ||
| code == 103 -> true | ||
| // Processing & Early Hints (103) but not supported yet in OkHttp |
There was a problem hiding this comment.
The comment is slightly misleading IMHO. Supporting 1xx codes means doing the same thing for all of them, except, well, for the exceptions (being 100 and 101).
It just means consuming the response, until final response is received (and potentially making the information about it available to the caller).
swankjesse
reviewed
Jan 4, 2023
okhttp/src/jvmMain/kotlin/okhttp3/internal/http/CallServerInterceptor.kt
Outdated
Show resolved
Hide resolved
swankjesse
reviewed
Jan 4, 2023
okhttp/src/jvmMain/kotlin/okhttp3/internal/http1/Http1ExchangeCodec.kt
Outdated
Show resolved
Hide resolved
swankjesse
approved these changes
Jan 4, 2023
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Jan 5, 2023
(cherry picked from commit 7e4576c)
swankjesse
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Ignore early hints for 4.9.x (#7444) (cherry picked from commit b565eec) * Expand 103 handling to other non-specific 1XX messages. (#7629) (cherry picked from commit 7e4576c) * Cleanup * Add a test of 103 handling * Add copyright * Add copyright * Fix cache test for 102/103 (#7633) (cherry picked from commit 930f138) * Disable test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic implementation for #2257
Continuation of #7479
It doesn't have special handling of 102, such as resetting any timeouts.