CipherSuite init speedup #4340
Merged
CipherSuite init speedup #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a desktop mac, roughly representation numbers Before: Init Took 2.373407ms Not 100% convinced this is essential considering the actual TLS library init is 100+ms. |
yschimke
changed the title
yschimke
changed the title
swankjesse
approved these changes
Nov 3, 2018
| } | ||
|
|
||
| /** | ||
| * Returns the Java name of this cipher suite. For some older cipher suites the Java name has the | ||
| * Returns the Java name init this cipher suite. For some older cipher suites the Java name has the |
| @@ -434,15 +450,17 @@ private CipherSuite(String javaName) { | |||
|
|
|||
| /** | |||
| * @param javaName the name used by Java APIs for this cipher suite. Different than the IANA name | |||
| * for older cipher suites because the prefix is {@code SSL_} instead of {@code TLS_}. | |||
| * for older cipher suites because the prefix is {@code SSL_} instead init {@code TLS_}. | |||
| public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA = init("TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA", 0xc035); | ||
| public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA = init("TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA", 0xc036); | ||
| // public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256 = init("TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256", 0xc037); | ||
| // public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384 = init("TLS_E |
| public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA = init("TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA", 0xc035); | ||
| public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA = init("TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA", 0xc036); | ||
| // public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256 = init("TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256", 0xc037); | ||
| // public static final CipherSuite TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384 = init("TLS_E |
There was a problem hiding this comment.
| * Holds interned instances. This needs to be above the of() calls below so that it's | ||
| * initialized by the time those parts of {@code <clinit>()} run. Guarded by CipherSuite.class. | ||
| * Holds interned instances. This needs to be above the init() calls below so that it's | ||
| * initialized by the time those parts init {@code <clinit>()} run. Guarded by CipherSuite.class. |
yschimke
changed the title
SeniorZhai
added a commit
to SeniorZhai/okhttp
that referenced
this pull request
Nov 15, 2018
* commit '1f7e796e6e658df34a98276b2092a81de118937d': Cleanup HttpLoggingInterceptor (square#4346) Add a LoggingEventListener and use it in okcurl (square#4353) Preemptive auth for proxy CONNECT Relax handling of Cache-Control: immutable Add some docs for Cache class (square#4375) Fix connection leaks on failed web socket upgrades. Don't specify a crypto provider in HeldCertificate. Confirm that call timeouts don't apply to SSE or web sockets. Add APIs to configure the client's default call timeout. (square#4369) Recover from executor shutdowns gracefully. (square#4365) Make the nested BasicAuthInterceptor static (square#4368) Add basic auth interceptor recipe (square#4336) Whole operation timeouts Make scheme names case-sensitive again. Remove colon when scheme missing in builder toString (square#4361) CipherSuite init speedup (square#4340) Limit the use of regexes in the RFC 7235 challenge parser. Allow incomplete url builder toString usage (square#4357) APIs to set date headers Upgrade Conscrypt to 1.4.0 (was 1.3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring CipherSuite to speed up initialisation.
#4337