Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect 100-continue does not appear to work #675

Closed
ifedorenko opened this issue Apr 4, 2014 · 2 comments
Closed

Expect 100-continue does not appear to work #675

ifedorenko opened this issue Apr 4, 2014 · 2 comments
Labels
bug Bug in existing code
Milestone
3.6

Comments

@ifedorenko
Copy link

This maybe my misunderstanding of HttpURLConnection API or HTTP protocol itself, but I can't get okhttp do Expect 100-continue handshake as described in rfc [1]. Identical code using standard HttpURLConnection implementation appears to work. [2] has is an example that shows both okhttp and jdk tests I did

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html
[2] https://github.com/ifedorenko/bug430772/blob/master/src/test/java/bug430772/Expect100ContinueTest.java
@swankjesse swankjesse added the bug label Apr 15, 2014
@swankjesse
Copy link
Collaborator

Yup, this is very broken.

@swankjesse swankjesse added this to the 3.0 milestone Apr 16, 2014
@swankjesse swankjesse modified the milestones: Icebox, 3.0 Nov 5, 2014
@swankjesse swankjesse mentioned this issue Jul 10, 2016
Closed
@swankjesse swankjesse modified the milestones: 3.5, Icebox, 3.6 Jul 10, 2016
zack-shoylev added a commit to rackspace/jclouds that referenced this issue Oct 13, 2016
@zack-shoylev
jclouds was not properly retrying on an expect: 100-continue PUT requ…
d897c5e 
…est that requires re-athentication because of java protocol code

JCLOUDS-1179 This fix also addresses the same problem with other providers

No currently working tests because of square/okhttp#675

This is a common problem in other tools as well https://curl.haxx.se/mail/lib-2004-08/0002.html
ghost pushed a commit to jclouds/jclouds that referenced this issue Oct 13, 2016
@zack-shoylev
jclouds was not properly retrying on an expect: 100-continue PUT requ…
00f7ee0 
…est that requires re-athentication because of java protocol code

JCLOUDS-1179 This fix also addresses the same problem with other providers

No currently working tests because of square/okhttp#675

This is a common problem in other tools as well https://curl.haxx.se/mail/lib-2004-08/0002.html
@ricellis ricellis mentioned this issue Nov 18, 2016
Closed
@swankjesse
Copy link
Collaborator

I started looking into this. Seems relatively straightforward. We need to add some special support in HTTP/2, since the 100: Continue comes back as a 2nd set of headers there.
http://httpwg.org/specs/rfc7540.html#rfc.section.8.1.3

swankjesse pushed a commit that referenced this issue Dec 23, 2016
@squarejesse
Support 'Expect: 100-continue' as a request header.
70eb8d0 
This will stall reading the response body until the server returns
an intermediate '100 Continue' response.

Closes: #675
@swankjesse swankjesse mentioned this issue Dec 23, 2016
Merged
swankjesse pushed a commit that referenced this issue Dec 24, 2016
@squarejesse
Support 'Expect: 100-continue' as a request header.
d5bde31 
This will stall reading the response body until the server returns
an intermediate '100 Continue' response.

Closes: #675
swankjesse pushed a commit that referenced this issue Dec 27, 2016
@squarejesse
Support 'Expect: 100-continue' as a request header.
a589b81 
This will stall reading the response body until the server returns
an intermediate '100 Continue' response.

Closes: #675
@guillerodriguez guillerodriguez mentioned this issue Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
3.6
Development

No branches or pull requests
2 participants
@ifedorenko @swankjesse