Change the adapter for Object.class to delegate. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightlyNexus
approved these changes
May 27, 2017
| * Confirm that the built-in adapter for Object delegates to user-supplied adapters for JSON value | ||
| * types like strings. | ||
| */ | ||
| @Test public void objectAdapterDelegatesStringNamesAndValues() throws Exception { |
There was a problem hiding this comment.
Any reason to put them in MoshiTest instead of ObjectAdapterTest?
There was a problem hiding this comment.
Yep, that’s better. Fixed.
Previously if we ever had an opaque Object, the content of this object would always only use the built-in adapters for its members. This changes the built-in Object adapter to do one layer of type checking and then to delegate to user-supplied adapters. The big upside of this is that application code can now change the default numeric type to use when decoding an untyped object. Typically this will be used to replace our default of Double with a user-specified numeric type like BigDecimal.
swankjesse
force-pushed
the
jwilson.0526.delegate_core_adapter
branch
from
ec5f962 to
9e9655b
Compare
JakeWharton
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we ever had an opaque Object, the content of this object
would always only use the built-in adapters for its members.
This changes the built-in Object adapter to do one layer of type checking
and then to delegate to user-supplied adapters.
The big upside of this is that application code can now change the default
numeric type to use when decoding an untyped object. Typically this will
be used to replace our default of Double with a user-specified numeric type
like BigDecimal.