Don't loop when storage permission denied #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
force-pushed
the
py/permission_loop
branch
from
b6ae111 to
f9ad46a
Compare
If the storage permission is denied, don't retry, just show a toast. Fixes #422
pyricau
force-pushed
the
py/permission_loop
branch
from
f9ad46a to
0b7cac4
Compare
|
@jrodbx I got a lint error because I was missing the german entry for that new string I added. Meh. |
Pengchengxiang
pushed a commit
to XLibrarys/leakcanary
that referenced
this pull request
Jan 2, 2017
Don't loop when storage permission denied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the storage permission is denied, don't retry, just show a toast.
Fixes #422