Fix delete button not working on error views - also move deletion logic to their own methods #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic to their own methods
| @@ -249,6 +281,12 @@ void updateUi() { | |||
| getActionBar().setDisplayHomeAsUpEnabled(true); | |||
| actionButton.setVisibility(VISIBLE); | |||
| actionButton.setText(R.string.leak_canary_delete); | |||
| actionButton.setOnClickListener(new View.OnClickListener() { | |||
| @Override | |||
| public void onClick(View v) { | |||
There was a problem hiding this comment.
@Override should be inlined. I'll format the file after merging.
pyricau
added a commit
that referenced
this pull request
Mar 19, 2016
Fix delete button not working on error views - also move deletion logic to their own methods
|
Thanks a lot! |
Pengchengxiang
pushed a commit
to XLibrarys/leakcanary
that referenced
this pull request
Jan 2, 2017
Fix delete button not working on error views - also move deletion logic to their own methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.