Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring SpellCheckerSessionListenerImpl leak #33

Merged
merged 1 commit into from
May 10, 2015
Merged

Ignoring SpellCheckerSessionListenerImpl leak #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions library/leakcanary-android/src/main/java/com/squareup/leakcanary/AndroidExcludedRefs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,13 @@ public static ExcludedRefs.Builder createAppDefaults() {
excluded.instanceField("android.animation.LayoutTransition$1", "val$parent");
}

if (SDK_INT >= JELLY_BEAN || SDK_INT <= LOLLIPOP_MR1) {
// SpellCheckerSessionListenerImpl.mHandler is leaking destroyed Activity when the
// SpellCheckerSession is closed before the service is connected.
// Tracked here: https://code.google.com/p/android/issues/detail?id=172542
excluded.instanceField("android.view.textservice.SpellCheckerSession$1", "this$0");
}

if (MOTOROLA.equals(MANUFACTURER) && SDK_INT == KITKAT) {
// DevicePolicyManager keeps a reference to the context it has been created with instead of
// extracting the application context. In this Motorola build, DevicePolicyManager has an
Expand Down Expand Up @@ -215,14 +222,6 @@ public static ExcludedRefs.Builder createAppDefaults() {
excluded.staticField("android.widget.TextView", "mLastHoveredView");
}

if (MOTOROLA.equals(MANUFACTURER) && SDK_INT == JELLY_BEAN) {
// android.view.textservice.SpellCheckerSession$SpellCheckerSessionListenerImpl.mHandler is
// a GC root, it's an inner class that references SpellCheckerSession which itself references
// a SpellChecker through SpellCheckerSession.mSpellCheckerSessionListener.
excluded.instanceField("android.view.textservice.SpellCheckerSession",
"mSpellCheckerSessionListener");
}

if (SAMSUNG.equals(MANUFACTURER) && SDK_INT == KITKAT) {
// android.app.LoadedApk.mResources has a reference to
// android.content.res.Resources.mPersonaManager which has a reference to
Expand Down