Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate StickyClass GC roots #2324

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Deduplicate StickyClass GC roots #2324

merged 1 commit into from
Apr 3, 2022
+53 −2

Commits on Apr 2, 2022

  1. Deduplicate StickyClass GC roots 

    System classes are GC roots and tracked by GcRoot.StickyClass. We've seen heap dumps from API 23 emulators that included millions of sticky class roots, pointing several times to the same instances. As we keep the list of roots in memory, this wasted a lot of memory and slowed down the sorting of gc roots which happens right before path finding. This change fixes this by deduplicating StickyClass GC roots based on their ids.
    @pyricau
    pyricau committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    2e22b9e View commit details
    Browse the repository at this point in the history