Add heapDumpDurationMillis to HeapAnalysis #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pyricau
reviewed
Sep 17, 2020
| @@ -65,12 +65,14 @@ internal class AndroidHeapDumper( | |||
| val toast = waitingForToast.get() | |||
|
|
|||
| return try { | |||
| Debug.dumpHprofData(heapDumpFile.absolutePath) | |||
| val durationMillis = measureTimeMillis { | |||
There was a problem hiding this comment.
measureTimeMillis is based on System.currentTimeMillis() which isn't recommended for measuring durations (not monotonically increasing).
There was a problem hiding this comment.
Good point. I have switched to a new util method which calls SystemClock.uptimeMillis()
pyricau
approved these changes
Sep 17, 2020
leakcanary-android-core/src/main/java/leakcanary/internal/AndroidHeapDumper.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/HeapAnalyzerService.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/HeapAnalyzerService.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/HeapAnalyzerService.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/HeapDumpTrigger.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/HeapDumper.kt
Outdated
Show resolved
Hide resolved
chao2zhang
commented
Sep 17, 2020
chao2zhang
force-pushed
the
master
branch
2 times, most recently
from
462399d
to
61e1a47
Compare
pyricau
approved these changes
Sep 18, 2020
leakcanary-android-core/src/main/java/leakcanary/internal/HeapAnalyzerService.kt
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/activity/db/HeapAnalysisTable.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-instrumentation/src/main/java/leakcanary/InstrumentationLeakDetector.kt
Outdated
Show resolved
Hide resolved
leakcanary-android-core/src/main/java/leakcanary/internal/activity/screen/HeapDumpScreen.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android 11, we have experienced slow heap dumps as described in https://issuetracker.google.com/issues/168634429.
The heap dump was still relatively quick for a vanilla sampe project, so I would like to contribute to leak canary to verify the heap dump in a large-scale app to support the arguments.
Implementation-wise, I used -1 as an invalid duration and the corresponding formatted text would be "UNKNOWN". If the duration for the heap dump is valid, the text would be like "42 ms".
I have tested this patch manually by installing on my device as well as running
./gradlew test. If there are other steps I need to take for testing, please let me know.