Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convert from v20: expect empty elements array #1800

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix convert from v20: expect empty elements array #1800

merged 1 commit into from
Apr 23, 2020

Conversation

ckesc
Copy link
Contributor

@ckesc ckesc commented Apr 22, 2020

Fixes #1797

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Armaxis
Armaxis approved these changes Apr 23, 2020
View reviewed changes
shark/src/main/java/shark/LeakTrace.kt Outdated Show resolved Hide resolved
@pyricau pyricau merged commit 5896b6d into square:master Apr 23, 2020
@pyricau
Copy link
Member

pyricau commented Apr 23, 2020

Thanks!!

@ckesc
Copy link
Contributor Author

ckesc commented Apr 30, 2020

@pyricau Can we release v2.2.1 or something with this bugfix? :) I really want to update to 2.2, but this bug blocks it.

@pyricau
Copy link
Member

pyricau commented Apr 30, 2020

cc @Armaxis let's check in on releasing 2.3

@pyricau
Copy link
Member

pyricau commented May 1, 2020

@ckesc I'm hoping to release 2.3 sometimes next week. Ping me again if that's not the case!

@ckesc
Copy link
Contributor Author

ckesc commented May 8, 2020

@pyricau How's 2.3 going? No pressure 😀

@pyricau
Copy link
Member

pyricau commented May 8, 2020

I'm writing the release notes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Armaxis Armaxis Armaxis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on upgrade 2.0 → 2.2
4 participants
@ckesc @CLAassistant @pyricau @Armaxis