Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hprof storage #1419

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Improve hprof storage #1419

merged 1 commit into from
Jun 28, 2019

Conversation

pyricau
Copy link
Member

@pyricau pyricau commented Jun 28, 2019

  • Added LeakCanary.Config.maxStoredHeapDumps (default 7) to enabling configuring how many hprof files are retained.
  • Added LeakCanary.Config.requestWriteExternalStoragePermission (default false) to stop having those pesky double LeakCanary notifications on first leak for most users.
  • Added tracking of why files were removed in case Crash, heap dump missing #1417 happens again.

@pyricau
Improve hprof storage
668f1cd 
* Added LeakCanary.Config.maxStoredHeapDumps (default 7) to enabling configuring how many hprof files are retained.
* Added LeakCanary.Config.requestWriteExternalStoragePermission (default false) to stop having those pesky double LeakCanary notifications on first leak for most users.
* Added tracking of why files were removed in case #1417 happens again.
@pyricau pyricau added this to the 2.0 Next Release milestone Jun 28, 2019
@pyricau pyricau merged commit 1b14b44 into master Jun 28, 2019
@pyricau pyricau deleted the py/storage branch June 28, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-alpha-3
Development

Successfully merging this pull request may close these issues.
1 participant
@pyricau