Simplify how we track retained instances. #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed HeapDumpMemoryStore * Simplified the "retained" concept by introducing a retained time for each weak ref. Then for all hprof old and new we just look at KeyedWeakReference instances which became retained before the heap dump time. If the field is missing (older hprofs) we assume all instances are retained. * This simplified a bunch of edge cases and removed the need to reporting cleared and missing references. * Also removed AnalysisBenchmarkTest which was ignored and didn't work. * Added RefWatcher.retainedInstances that can be used for logging purposes. Fixes #1366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1366