[DO NOT MERGE] Tmp work for exploring Q leak #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
commented
Jun 21, 2019
| @@ -105,7 +105,9 @@ class HeapAnalyzer constructor( | |||
| ) | |||
| val analysisResults = mutableMapOf<String, RetainedInstance>() | |||
| listener.onProgressUpdate(FINDING_WATCHED_REFERENCES) | |||
| val (retainedKeys, heapDumpUptimeMillis) = readHeapDumpMemoryStore(parser) | |||
There was a problem hiding this comment.
Done porting back changes from this file.
pyricau
commented
Jun 21, 2019
| @@ -205,7 +205,7 @@ internal object LeakingInstanceTable { | |||
| val groupLeakTrace = if (leakingInstance.exclusionStatus == WONT_FIX_LEAK) { | |||
| val index = leakTrace.elements.indexOfFirst { element -> element.exclusion != null } | |||
| LeakTrace( | |||
| elements = listOf(leakTrace.elements[index]) | |||
| elements = listOf(leakTrace.elements[index].copy(labels = emptyList())) | |||
There was a problem hiding this comment.
Done porting back changes from this file.
pyricau
commented
Jun 21, 2019
|
|
||
| if (record is InstanceDumpRecord && parser.className( | ||
| record.classId | ||
| ) == "android.view.ViewRootImpl" |
There was a problem hiding this comment.
TODO port this back or find alternative
pyricau
commented
Jun 21, 2019
|
|
||
| if (record is InstanceDumpRecord && parser.className( | ||
| record.classId | ||
| ) == "android.view.inputmethod.InputMethodManager" |
pyricau
commented
Jun 21, 2019
| var currentRecord = record | ||
| while ((currentRecord is InstanceDumpRecord && parser.className( | ||
| currentRecord.classId | ||
| ) in listOf("flow.path.PathContext", "flow.path.Path\$LocalPathWrapper", "mortar.MortarContextWrapper")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this should make it back to master but I'll need to take it out piece by piece