-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidLeakFixes$TEXT_LINE_POOL should not hold TextLine.sCached #2471
Comments
pyricau
added a commit
that referenced
this issue
Feb 8, 2023
Somehow Google tests surfaced that AndroidLeakFixes was on the shortest path to TextLine.sCached which makes no sense. Let's make sure we're never there again. Fixes #2471
I'm not sure if having additional reports of this helps, but I believe we are seeing the same, in our leak detecting instrumentation tests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure why but Google's CI found that the code that's attempting to clear the sCached leak ends up on the shortest path for that leak, which makes no sense. The best way to avoid that is simply to not cache sCached but instance retrieve it each time, which isn't all that costly anyway.
Related to https://android-review.googlesource.com/c/platform/frameworks/support/+/2420704/2#message-f6a1392ab5b07a2aed5111e5ca410cf0eaaf00b6
The text was updated successfully, but these errors were encountered: