Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X home button to LeakCanary #2069

Closed
pyricau opened this issue Feb 11, 2021 · 1 comment · Fixed by #2102
Closed

Add X home button to LeakCanary #2069

pyricau opened this issue Feb 11, 2021 · 1 comment · Fixed by #2102
Labels
good first issue status: help wanted type: enhancement
Milestone
2.7

Comments

@pyricau
Copy link
Member

pyricau commented Feb 11, 2021

Some Android devices don't have a back button (👀). When LeakCanary is on the first screen of the backstack, we should have the home button be an X so that they can leave the app.
@CharlesAdam
Copy link

Some Android devices don't have a back button (👀). When LeakCanary is on the first screen of the backstack, we should have the home button be an X so that they can leave the app.

Do you mean the android navigation bar or the title bar?

pyricau added a commit that referenced this issue Mar 26, 2021
@pyricau
Add X home button to LeakCanary
79923b4 
Fixes #2069
@pyricau pyricau mentioned this issue Mar 26, 2021
Merged
@pyricau pyricau added this to the 2.7 milestone Mar 26, 2021
ghost pushed a commit to shivagowda/leakcanary that referenced this issue Nov 8, 2021
@pyricau
Add X home button to LeakCanary
61a82c4 
Fixes square#2069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue status: help wanted type: enhancement
Projects
None yet
Milestone
2.7
Development

Successfully merging a pull request may close this issue.

Add X home button to LeakCanary square/leakcanary
2 participants
@pyricau @CharlesAdam