Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new LeakCanary Plumber library #1295

Closed
pyricau opened this issue Apr 24, 2019 · 5 comments · Fixed by #1591
Closed

Add new LeakCanary Plumber library #1295

pyricau opened this issue Apr 24, 2019 · 5 comments · Fixed by #1591
Milestone

Comments

@pyricau
Copy link
Member

pyricau commented Apr 24, 2019

This would be essentially the mirror of AndroidExcludedRef, a production library that uses various hacks to clean up framework leaks.

@pyricau pyricau added this to the 2.0 Next Release milestone Apr 24, 2019
@pyricau
Copy link
Member Author

pyricau commented Apr 24, 2019

cc @bishiboosh who mentioned that idea

@pyricau
Copy link
Member Author

pyricau commented May 5, 2019

Some leaks have clear triggers on when to try and fix them, while others less so and we've typically used a timer based approach in the past.

I'm thinking instead we could on top of LeakSentry and attempt clearing things when LeakSentry lets us know there are leaking instances. That likely means having an intermediate report step where the sniper snoops in and reports and LeakCanary does not immediately dump / retries later.

@pyricau
Copy link
Member Author

pyricau commented May 5, 2019

The viewgroup leak in P is definitely worth looking at fixing: #1081 (comment)

@pyricau pyricau modified the milestones: 2.0-alpha-2, 2.0 Next Release May 21, 2019
@pyricau pyricau modified the milestones: 2.0-alpha-3, 2.0 Next Release Jul 4, 2019
@pyricau
Copy link
Member Author

pyricau commented Jul 5, 2019

@pyricau pyricau modified the milestones: 2.0-beta-1, 2.0 Next Release Jul 26, 2019
@pyricau pyricau modified the milestones: 2.0-beta-2, 2.0 Next Release Aug 2, 2019
@pyricau pyricau removed this from the 2.0 Next Release milestone Aug 22, 2019
pyricau added a commit that referenced this issue Sep 19, 2019
@pyricau pyricau added this to the 2.0 Next Release milestone Sep 19, 2019
pyricau added a commit that referenced this issue Sep 19, 2019
@pyricau pyricau removed this from the 2.0-beta-4 milestone Nov 19, 2019
pyricau added a commit that referenced this issue May 19, 2020
@pyricau pyricau added this to the 2.4 milestone May 19, 2020
@pyricau
Copy link
Member Author

pyricau commented May 19, 2020

Note: I went with the timer based approach rather than relying on signals from the app watcher because that way we don't have a direct dependency on it.

@pyricau pyricau changed the title Add new LeakCanary Sniper library Add new LeakCanary Plumber library May 19, 2020
bishiboosh pushed a commit to bishiboosh/leakcanary that referenced this issue May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant