-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group leaks by identified possible causes #1202
Comments
Also worth grouping compiled lambdas (which name change with each compile run). Need to build a list of examples:
|
We've got an interesting edge case when it comes to grouping: different parts of the hashmap implementation pointing to the same object lead to different leak traces. Leak Canary picks any of the shortests paths. Makes we wonder if we should sort those and pick the first, to have more consistent results and grouping. |
Need to update the UI to display leak groups first, then you open one group and see the group summary (ie subpart of leak trace) and a list of all instances and then you can dive in on any of those and you'll see a full leak trace. |
Also we will need to fix #1209 |
|
This is done, although we need to polish the UI some more. |
What matters when investigating leaks is not what we're leaking or what the gc root is, but what the possible causes are. Experience has shown that the same leak can lead to an activity, a fragment, or a view leaking. We can use the new reachability data to use the parts of the leak trace that are identified are possible cause as a grouping hash.
This is showing promising results internally at Square for remote reporting and grouping.
We should also group together all leaks excluded by the same exclusion.
The text was updated successfully, but these errors were encountered: