Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion on individual leaks in DisplayActivity #1183

Closed
jrodbx opened this issue Feb 12, 2019 · 2 comments
Closed

Allow deletion on individual leaks in DisplayActivity #1183

jrodbx opened this issue Feb 12, 2019 · 2 comments

Comments

@jrodbx
Copy link
Collaborator

jrodbx commented Feb 12, 2019

Thanks to #1081, I get a bunch of false alarms which I ignore.

Occasionally, I get a leak I want to dig into more, but it's surrounded by those ignorable false positives. The ability to long-press + multiple select + delete a set of leaks would be a nice feature to have here.

@pyricau pyricau added this to the 2.0 milestone Mar 30, 2019
@pyricau
Copy link
Member

pyricau commented Mar 30, 2019

Note: this should happen after #1202 (which changes the UX by adding groups)

@pyricau pyricau modified the milestones: 2.0-alpha-1, 2.0 Next Release May 1, 2019
@pyricau pyricau modified the milestones: 2.0-alpha-2, 2.0 Next Release May 21, 2019
@pyricau pyricau modified the milestones: 2.0-alpha-3, 2.0 Next Release Jul 4, 2019
@pyricau pyricau modified the milestones: 2.0-beta-1, 2.0 Next Release Jul 26, 2019
@pyricau pyricau modified the milestones: 2.0-beta-2, 2.0 Next Release Aug 2, 2019
@pyricau pyricau removed this from the 2.0 Next Release milestone Aug 22, 2019
@pyricau
Copy link
Member

pyricau commented Dec 7, 2020

Closing this:

  • Deleting a single leak is tricky as a leak is part of a heap dump which contains multiple leaks. So from a user standpoint there's no clarity around what "deleting a leak" might mean.
  • The new organization means leaks are grouped so we don't have all these entries, so the need to delete individual leaks is probably not as high..

@pyricau pyricau closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants