Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to add ExcludedRefs #12

Closed
cypressious opened this issue May 9, 2015 · 1 comment
Closed

Add API to add ExcludedRefs #12

cypressious opened this issue May 9, 2015 · 1 comment

Comments

@cypressious
Copy link
Contributor

We have the AndroidExcludedRefs which is nice. But please add an API to define our own excludes.
@cypressious cypressious mentioned this issue May 9, 2015
Closed
@pyricau
Copy link
Member

pyricau commented May 10, 2015

So we basically need to pass an instance of ExcludedRef to the analysis service. I think the easiest approach will be to make that serializable, and include it in the HeapDump instance. The RefWatcher should get one in its constructor. Then we can use the default in LeakCanary, and one could also provide their own.

pyricau added a commit that referenced this issue May 10, 2015
@pyricau
Customizable ExcludedRef
c2d938f 
* ExcludedRef is immutable, added ExcludedRef.Builder to create one.
* AndroidExcludedRef returns a ExcludedRef.Builder
* ExcludedRef is Serializable and belongs to HeapDump, it now gets passed from the RefWatcher. This also makes the saved result more coherent.
* Moved ExcludedRef from analyzer to watcher module

Fix for #12
@pyricau pyricau mentioned this issue May 10, 2015
Merged
@pyricau pyricau closed this as completed May 13, 2015
Yky pushed a commit to Yky/leakcanary that referenced this issue Feb 21, 2016
@pyricau
Customizable ExcludedRef
23a4793 
* ExcludedRef is immutable, added ExcludedRef.Builder to create one.
* AndroidExcludedRef returns a ExcludedRef.Builder
* ExcludedRef is Serializable and belongs to HeapDump, it now gets passed from the RefWatcher. This also makes the saved result more coherent.
* Moved ExcludedRef from analyzer to watcher module

Fix for square#12
@ttsy-80 ttsy-80 mentioned this issue Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pyricau @cypressious