Service/analyzer process detection is wrong

[andrii-borysov-me]

Methods LeakCanary.isInAnalyzerProcess and LeakCanaryInternals.isInServiceProcess don't recognize when they are called in the ":leakcanary" process, if no memory leak has happened yet (or when all memory leaks are fixed).

Steps to reproduce:

1. Create new android app from "Empty Activity" template.
2. Add LeakCanary dependency following the Getting Started section.
3. Add ExampleApplication class with installing LeakCanary following the Getting Started section.
4. Launch the main app on a device or emulator.
5. Launch the Leaks app.

Actual result:

• On step 4, LeakCanary.isInAnalyzerProcess returns false,
• On step 5, LeakCanary.isInAnalyzerProcess returns false.

Expected result:

• On step 4, LeakCanary.isInAnalyzerProcess returns false,
• On step 5, LeakCanary.isInAnalyzerProcess returns true.

The reason of the issue is that the HeapAnalyzerService as well as DisplayLeakService are disabled until any first leak happens, and the method LeakCanaryInternals.isInServiceProcess does not fetch "disabled" components and swallows PackageManager.NameNotFoundException by returning false in this case.

In a simple app, this issue is not critical, but in my case I get java.lang.IllegalStateException: Default FirebaseApp is not initialized in this process *:leakcanary. Make sure to call FirebaseApp.initializeApp(Context) first., which is annoying.

Here is the sample project to reproduce: LeakCanaryCheckProcessIssue.zip

[pyricau]

Thanks! Yep, this is definitely a bug.