Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncSession: correct (stream_)scalars arg name #238

Merged
merged 1 commit into from
Oct 11, 2022
Merged

AsyncSession: correct (stream_)scalars arg name #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sqlalchemy-stubs/ext/asyncio/session.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ class _AsyncSessionProtocol(
async def scalars(
self,
statement: Executable,
parameters: Optional[_ExecuteParams] = ...,
params: Optional[_ExecuteParams] = ...,
execution_options: Optional[_ExecuteOptions] = ...,
) -> ScalarResult: ...
async def stream_scalars(
self,
statement: Executable,
parameters: Optional[_ExecuteParams] = ...,
params: Optional[_ExecuteParams] = ...,
execution_options: Optional[_ExecuteOptions] = ...,
) -> AsyncScalarResult: ...
async def delete(self, instance: Any) -> None: ...
Expand Down Expand Up @@ -211,13 +211,13 @@ class _AsyncSessionTypingCommon(
async def scalars(
self,
statement: Executable,
parameters: Optional[_ExecuteParams] = ...,
params: Optional[_ExecuteParams] = ...,
execution_options: Optional[_ExecuteOptions] = ...,
) -> ScalarResult: ...
async def stream_scalars(
self,
statement: Executable,
parameters: Optional[_ExecuteParams] = ...,
params: Optional[_ExecuteParams] = ...,
execution_options: Optional[_ExecuteOptions] = ...,
) -> AsyncScalarResult: ...
@classmethod
Expand Down
8 changes: 4 additions & 4 deletions test/files/async_stuff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@


async def go() -> None:
r = await async_session.scalars(text("select 1"))
r = await async_session.scalars(text("select 1"), params=[])
CaselIT marked this conversation as resolved.
Show resolved Hide resolved
r.first()
sr = await async_session.stream_scalars(text("select 1"))
sr = await async_session.stream_scalars(text("select 1"), params=[])
await sr.all()
r = await as_session.scalars(text("select 1"))
r = await as_session.scalars(text("select 1"), params=[])
r.first()
sr = await as_session.stream_scalars(text("select 1"))
sr = await as_session.stream_scalars(text("select 1"), params=[])
await sr.all()

async with engine.connect() as conn:
Expand Down