Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add harmless OpenCL warning to bening errors (IPython console) #22575

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 25, 2024

Description of Changes

That warning happens during env activation and prevents the console from starting. But it's not an error that doesn't allow the kernel to work.

Issue(s) Resolved

Fixes #22551

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12
Copy link
Member Author

@meltingSnowdrift, could you apply this small change to your Spyder installation and see if it fixes the problem you reported on issue #22551? Thanks!

@meltingSnowdrift
Copy link

I have just tried this and it works. Thank you, again, quite seriously.

I am slightly concerned, however, that this solution may incorrectly ignore many other unrelated error messages which happen to contain the same text but are much more serious in their causes. For example, some other user will quite likely make a genuinely misconfigured environment which really is broken for a reason related to a file not being found. Could it be desirable in the future to display such "harmless" error messages in some way which is not annoying but still readable to the user to help the user diagnose the potential real problems they may sometimes be associated with?

Alternately, could it be desirable to keep the previous behaviour (which made my environment unusable in Spyder) as default, but add an option in the environment selection screen of the settings window to try to open a console regardless of any error messages generated upon activating an environment? This way, people in my situation would be able to override the effects of error messages by manually turning on that option, but people with a genuinely broken environment would not be presented with a nonworking console without an explanation.

I hope this will not be the kind of fix that makes things work for me but causes future confusion for many other people. Thank you again for your patience and effort.

@ccordoba12
Copy link
Member Author

I have just tried this and it works. Thank you, again, quite seriously.

Great! Thanks for testing.

I am slightly concerned, however, that this solution may incorrectly ignore many other unrelated error messages which happen to contain the same text but are much more serious in their causes.

I thought about that too, but real kernel activation or startup Python errors leave the console unusable. And in that case, I guess users will report those problems to us.

Could it be desirable in the future to display such "harmless" error messages in some way which is not annoying but still readable to the user to help the user diagnose the potential real problems they may sometimes be associated with?

The problem is those messages make very little sense (you probably saw our list of benign messages), even if we printed them in the console. So I think that'd be more annoying that useful.

Alternately, could it be desirable to keep the previous behaviour (which made my environment unusable in Spyder) as default, but add an option in the environment selection screen of the settings window to try to open a console regardless of any error messages generated upon activating an environment?

This is a not a bad idea but (a) users will have to do the extra step of opening a new console every time, even if they know the message is unimportant; and (b) we don't have the resources to implement that right now.

I hope this will not be the kind of fix that makes things work for me but causes future confusion for many other people. Thank you again for your patience and effort.

I understand your concern but I think in this case it's justified.

@ccordoba12
Copy link
Member Author

I'd also would like to ask you if, after applying my changes, you're also seeing the The system cannot find the path specified message in the console after running any computation (e.g. 1 + 1).

I think some people reported that before, so I'd like to double check with you.

@ccordoba12
Copy link
Member Author

@meltingSnowdrift, any updates about the question I asked you in my last comment?

@meltingSnowdrift
Copy link

I do not see any such messages. Sorry for forgetting to answer this. Thank you for your patience.

@ccordoba12
Copy link
Member Author

Thanks for your help @meltingSnowdrift!

@ccordoba12 ccordoba12 merged commit 2d41ff2 into spyder-ide:master Oct 7, 2024
14 checks passed
@ccordoba12 ccordoba12 deleted the issue-22551 branch October 7, 2024 17:03
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Oct 7, 2024
ccordoba12 pushed a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message "the system cannot find the path specified" upon trying to start the kernel
2 participants