Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix several errors with missing plugins when setting a layout #22288

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 25, 2024

Description of Changes

  • We were not setting layouts correctly if the first plugin in the layout's area is missing.
  • Also, tabify any plugin not available during the previous session (before we were doing that only for external plugins). That will include internal plugins that were automatically disabled in the first session (e.g. Help).
  • I found these problems while testing Spyder without WebEngine.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@pep8speaks
Copy link

pep8speaks commented Jul 25, 2024

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 465:54: E203 whitespace before ':'

Comment last updated at 2024-07-25 17:21:56 UTC

@ccordoba12 ccordoba12 changed the title PR: Deal with missing plugins when setting a layout PR: Fix several errors with missing plugins when setting a layout Jul 25, 2024
Also, fix some small style issues and remove an unused import
@ccordoba12 ccordoba12 force-pushed the fix-layout-with-missing-plugins branch from a51874e to 90b2b1a Compare July 25, 2024 15:44
Also, give focus to the Variable Explorer if Help is not available the
first time Spyder starts.
@ccordoba12 ccordoba12 merged commit b40f192 into spyder-ide:5.x Jul 25, 2024
23 checks passed
@ccordoba12 ccordoba12 deleted the fix-layout-with-missing-plugins branch July 25, 2024 22:32
ccordoba12 added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants