Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update QtAwesome version constraint to >=1.3.1,<1.4.0 #21939

Merged
merged 3 commits into from
Mar 29, 2024
Merged

PR: Update QtAwesome version constraint to >=1.3.1,<1.4.0 #21939

merged 3 commits into from
Mar 29, 2024

Conversation

dalthviz
Copy link
Member

Description of Changes

Update QtAwesome version constraint to >=1.3.1,<1.4.0 and get fix for font issue installation error on Windows

Issue(s) Resolved

Part of #21936

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.5.4 milestone Mar 29, 2024
@dalthviz dalthviz self-assigned this Mar 29, 2024
@dalthviz dalthviz mentioned this pull request Mar 29, 2024
Closed
@ccordoba12 ccordoba12 changed the title Update QtAwesome version constraint to >=1.3.1,<1.4.0 PR: Update QtAwesome version constraint to >=1.3.1,<1.4.0 Mar 29, 2024
@ccordoba12
Copy link
Member

@dalthviz, it seems you need to include the boltons package in installers-conda/build-environment.yml to fix the error when building our Linux installer.

It seems that's a boa dependency but it's weird it's not pulled by it.

@dalthviz
Copy link
Member Author

dalthviz commented Mar 29, 2024 •
edited
Loading

Note: The missing boltons error seems related with this commit message mentioning that for conda 23.4+ boltons will not be part of the vendored packages (mamba-org/boa@776609b). Also, seems like there is already an issue related with the missing update of the package recipe in conda-forge (conda-forge/boa-feedstock#81). Seems like boa version 0.17.0 from conda-forge doesn't have the updated dependency on boltons

@ccordoba12
Copy link
Member

ccordoba12 commented Mar 29, 2024 •
edited
Loading

Note: The missing boltons error seems related with this commit message mentioning that for conda 23.4+ boltons will not be part of the vendored packages (mamba-org/boa@776609b). Also, seems like there is already an issue related with the missing update of the package recipe in conda-forge (conda-forge/boa-feedstock#81). Seems like boa version 0.17.0 from conda-forge doesn't have the updated dependency on boltons

I saw that too and sent them conda-forge/boa-feedstock#82 to fix that.

ccordoba12
ccordoba12 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit d91fb55 into spyder-ide:5.x Mar 29, 2024
23 checks passed
ccordoba12 added a commit that referenced this pull request Mar 30, 2024
@ccordoba12
Merge from 5.x: PR #21939
4b34f79
@ccordoba12 ccordoba12 mentioned this pull request Mar 30, 2024
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Apr 2, 2024
@bmwiedemann
Update spyder to version 5.5.3 / rev 52 via SR 1163542
44ddf4f 
https://build.opensuse.org/request/show/1163542
by user bnavigator + anag+factory
- Update to 5.5.3
  * Fix critical error when starting IPython console kernels on
    macOS and Linux in conda environments.
- Release 5.5.2
  * Activate environment for consoles that run in the same
    environment as Spyder.
  * Fix IPython kernel hangs when using a different graphic backend
    than Inline.
  * Fix check for updates mechanism when running Spyder from a
    conda installation.
- Add spyder-pr21939-qtawesome1.3.patch gh#spyder-ide/spyder#21939
  but also allow 1.2
- Add spyder-pr21942-pylint3.1.patch gh#spyder-ide/spyder#21942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v5.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@dalthviz @ccordoba12