Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix issue where statusbar status was not updated properly after checking for updates #21436

Merged
merged 2 commits into from
Oct 21, 2023
Merged

PR: Fix issue where statusbar status was not updated properly after checking for updates #21436

merged 2 commits into from
Oct 21, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 19, 2023

Fix an issue where the statusbar status "Checking for updates..." would persist after WorkerUpdates completed. See: #21423 (comment)

@mrclary mrclary self-assigned this Oct 19, 2023
@mrclary mrclary added this to the v5.5.0 milestone Oct 19, 2023
ccordoba12
ccordoba12 reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny suggestion for you @mrclary.

spyder/plugins/application/container.py Outdated Show resolved Hide resolved
dalthviz
dalthviz approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this @mrclary ! Checked locally and things are working as expected 👍

installer_status_bar

@mrclary @ccordoba12
Apply suggestion from code review
6ce3395 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
ccordoba12 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 6b31570 into spyder-ide:5.x Oct 21, 2023
22 checks passed
ccordoba12 added a commit that referenced this pull request Oct 21, 2023
@ccordoba12
Merge from 5.x: PR #21436
5641ab4
@mrclary mrclary deleted the status-bar branch October 21, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@dalthviz dalthviz dalthviz approved these changes

Assignees

@mrclary mrclary

Labels
Installers type:Bug
Projects
None yet
Milestone
v5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrclary @ccordoba12 @dalthviz