Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instructions for changing environments in FAQ #199

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

juanis2112
Copy link
Contributor

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

I updated the FAQ question for changing environments in Spyder according to the new implementation for 4.2

Issue(s) Resolved

Fixes #197

@CAM-Gerlach CAM-Gerlach changed the title Updated instructions for changing environments in faq Updated instructions for changing environments in FAQ Nov 5, 2020
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a broader note, I tested the changes in spyder-ide/spyder#13950 as currently merged to 4.x, and I think I must be missing something important, which affects my suggestions on this PR.

The only visible difference I can see is in the status bar environment widget, which offers a popup with slightly quicker access to the environments preferences pan, and it displays the full path to the current environment rather than just the name. Otherwise, I can't seem to find any meaningful difference in the UI/UX, of the following things I tested that seemed like they might be affected that would simplify the procedure described here and justify the removal of several steps...but I suspect something is just not working for me:

  • None of my conda environments are displayed automatically, so I need to manually browse for them
  • Trying to browse for one still starts in the home dir rather than the Anaconda base dir or envs dir, so I still need to find the path via sys.executable
  • I can't seem to add an environment by just navigating to its directory rather than having to find the executable, so I still need to know what to add to the path per platform
  • When I add an environment, it doesn't show up in the status bar list and I still have to go all the way into preferences to select it, just like the tedious UX before.

So I'm not sure what this is supposed to change, nor why I'm not seeing it. As such, I still need to manually browse to the desired path, which is not mentioned here. The env path is listed in the status bar rather than just the env name, so users can manually type it out from there instead of copy/pasting it from their terminal, but that's potentially error prone, and still requires manually appending the executable and bin directory names depending on the platform, so I don't think we should recommend that approach. Regardless, that's not mentioned either, so I'm not sure what I'm missing here.

doc/faq.rst Outdated Show resolved Hide resolved
doc/faq.rst Outdated Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

To fix the build, on line 50 of conf.py, we need to change it to read

panels_add_bootstrap_css = False

instead, looks like it was mispelled in Sphinx-Panels originally and then they fixed it later.

@ccordoba12
Copy link
Member

ccordoba12 commented Nov 6, 2020

As a broader note, I tested the changes in spyder-ide/spyder#13950 as currently merged to 4.x, and I think I must be missing something important, which affects my suggestions on this PR.
So I'm not sure what this is supposed to change, nor why I'm not seeing it.

Sorry @CAM-Gerlach, this feature was broken on Windows and I just noticed it yesterday while helping @dalthviz to fix other issues with the Windows installer.

I'm about to push a PR that will make things work on Windows as @juanis2112 described them on Mac. I'll ping you there so you can test it.

juanis2112 and others added 2 commits November 9, 2020 12:18
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
doc/faq.rst Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @juanis2112 for your help with this one!

@CAM-Gerlach CAM-Gerlach merged commit 5a85355 into master Nov 9, 2020
@ccordoba12 ccordoba12 deleted the environments-faq branch November 9, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FAQ question on switching environments and interpreters based on the new implementation
3 participants