PR: Add Python 3.9 compatibility for collections.abc module
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure the build failures in some of the pipelines are related to my PR. |
tirkarthi
changed the title
goanpeca
reviewed
Mar 12, 2020
|
@goanpeca it might be nicer to use it seems that it would be more idiomatic to use |
CAM-Gerlach
changed the title
dalthviz
changed the title
dalthviz
reviewed
Aug 7, 2021
Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co>
|
Hi @tirkarthi , after talking with @ccordoba12 I will do some changes here to wrap up the work and move forward for the release (basically removing the PY33 logic and the line for the widgets iteration to then follow up the widgets change at #224). Hope this is ok with you @tirkarthi :) |
dalthviz
changed the title
collections.abc module
dalthviz
approved these changes
Aug 10, 2021
|
Thanks @dalthviz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImportErrorin Python 3.9 and raisesDeprecationWarningfrom 3.4 . Hence usecollections.abcand also preserve compatibility with Python 2. Ref : bpo-25988: Do not expose abstract collection classes in the collections module. python/cpython#10596Uselistinstead of deprecated getchildren in Python 3. DeprecationWarning for getchildren #206 PySide2 and Python3.9: xml.etree.ElementTree.Element' object has no attribute 'getchildren #238