FRW-8801 Dropped PHP 8.0 support. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vol4onok
approved these changes
Sep 9, 2024
kraal-spryker
approved these changes
Sep 19, 2024
asmarovydlo
suggested changes
Sep 19, 2024
| @@ -23,7 +23,7 @@ class DeployYamlFilesPhpVersionStrategy implements PhpVersionCheckerStrategyInte | |||
| /** | |||
| * @var string | |||
| */ | |||
| public const MESSAGE_USED_NOT_ALLOWED_PHP_VERSION = "Deploy file uses not allowed PHP image version \"%s\"\nImage tag must contain allowed PHP version (image:abc-8.0)"; | |||
| public const MESSAGE_USED_NOT_ALLOWED_PHP_VERSION = "Deploy file uses not allowed PHP image version \"%s\"\nImage tag must contain allowed PHP version (image:abc-8.1)"; | |||
There was a problem hiding this comment.
We need this change to module to work properly, let's release it instead of merge.
asmarovydlo
approved these changes
Sep 20, 2024
gechetspr
deleted the
feature/frw-8801/master-php-upgrade-and-drop-81
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @olhalivitchuk
Ticket: https://spryker.atlassian.net/browse/FRW-8801
Release Group: https://release.spryker.com/release-groups/view/5551
merge: squash
Release Table
Module Evaluator
Change log
Improvements
PHP 8.3support.Checklist