Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the lifetime in EcdsaXi2023. #2

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

timothee-haudebourg
Copy link
Collaborator

The extra data is now passed by copy, instead of by reference. This is not ideal from a memory performance point of view, but that's the only way to get around the compler issue rust-lang/rust#100013
Fixes #1

The extra data is now passed by copy.
Fixes #1
@timothee-haudebourg
Copy link
Collaborator Author

@Juliano1612 can you try this branch see if it solves your issue?

Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@timothee-haudebourg timothee-haudebourg merged commit 4d078d5 into main Aug 7, 2024
@timothee-haudebourg timothee-haudebourg deleted the timothee-haudebourg/issue1 branch August 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The verify method triggers rust-lang/rust#100013
2 participants