Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did:pkh - Public Key Hash DID method #124

Closed
wants to merge 2 commits into from

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 15, 2021

Implement #123

Depends on #133

  • Add DID method skeleton
  • Decide on DID format. Decided: it will be like did:pkh:tz:…, did:pkh:eth:…, did:pkh:btc:…
  • Enable proof types used with did:tz
  • Test DID resolution
  • Test LD-Proofs
  • DID generation from JWK? For didkit key-to-did: would need a way to indicate the pkh subtype.
  • Support addresses for Tezos and Ethereum
  • Support Bitcoin addresses
  • Represent Solana addresses? Yes, they appear to use the identity hash. Note: verifying SolanaMethod2021 is not yet implemented.
  • Support blockchainId property
  • Support Dogecoin addresses

@wyc
Copy link
Contributor

wyc commented Mar 16, 2021

IMO, we can reasonably claim that Solana uses the identity hash function.

@clehner clehner force-pushed the feat/did-pkh branch 2 times, most recently from 9034dfa to 6bb3077 Compare March 17, 2021 20:51
@clehner clehner changed the base branch from main to feat/method-pattern March 19, 2021 19:55
@clehner clehner marked this pull request as ready for review March 19, 2021 20:39
@clehner clehner changed the title [WIP] did:pkh - Public Key Hash DID method did:pkh - Public Key Hash DID method Mar 19, 2021
@wyc
Copy link
Contributor

wyc commented Mar 20, 2021

This is looking great. Could we also add support for dogecoin?

@ChristopherA
Copy link

I’d love to see support for did:onion. We already have a working server at http://fscst5exmlmr262byztwz4kzhggjlzumvc2ndvgytzoucr2tkgxf7mid.onion/ and example but real did:onion did document at http://fscst5exmlmr262byztwz4kzhggjlzumvc2ndvgytzoucr2tkgxf7mid.onion/.well-known/did.json

Code for server at: https://github.com/BlockchainCommons/torgap-demo

Basically did:onion uses 25519 keys but encoded in the onion address url rather than base64 or hex, can work like did:key or did:web, but has the advantage of no dns and no correlation of either the client or server. Getting the current did:document also serves as proof of control of the private key as you can’t receive it over the onion protocol unless you control it.

We also have a Open Time Stamp service available at , which can serve as a proof of existence on a particular date for did:documents or VCs. http://3xcaaswwserqnox56z7d7wifwyxm2jsdv4fniffym5jwncqx3qr7uzid.onion/

/cc @gorazdko

@clehner clehner mentioned this pull request Mar 21, 2021
@clehner
Copy link
Contributor Author

clehner commented Mar 21, 2021

@wyc yes, we can add a pkh:doge.

@ChristopherA thanks for the info; I've opened a new issue to track did:onion: #134

@wyc wyc requested review from sbihel, wyc and chunningham March 22, 2021 17:33
src/ldp.rs Show resolved Hide resolved
@wyc
Copy link
Contributor

wyc commented Mar 29, 2021

@clehner did you want to squash your fixups prior to commit? Otherwise I will merge tomorrow evening ET. Thanks!

@clehner
Copy link
Contributor Author

clehner commented Mar 30, 2021

@wyc I will rebase and squash these changes shortly.

@clehner
Copy link
Contributor Author

clehner commented Mar 30, 2021

Squashed related commits, rebased, and updated changelog.

Edit: CI failed due to #150

@clehner
Copy link
Contributor Author

clehner commented Apr 1, 2021

Rebased

@clehner
Copy link
Contributor Author

clehner commented Apr 1, 2021

Merged.

@clehner clehner closed this Apr 1, 2021
@clehner clehner deleted the feat/did-pkh branch April 1, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants