Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure encoding/decoding function return Send futures. #3

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Ensure encoding/decoding function return Send futures. #3

merged 1 commit into from
Aug 7, 2024

Conversation

timothee-haudebourg
Copy link
Collaborator

Fixes #2

@timothee-haudebourg
Copy link
Collaborator Author

timothee-haudebourg commented Aug 7, 2024 •
edited
Loading

Interestingly it seems the rust-lang/rust#100013 issue was not triggered by AFIT, but a simple lifetime parameter in the Transformer trait. The issue persisted even when all AFIT were removed from this trait. I removed the lifetime, but this means the codecs and tables can now only be passed by move or static reference (not any reference anymore)

@timothee-haudebourg timothee-haudebourg merged commit 74a439a into main Aug 7, 2024
@timothee-haudebourg timothee-haudebourg deleted the timothee-haudebourg/issue2 branch August 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure encoding/decoding function return Send futures.
1 participant
@timothee-haudebourg