Feature/wagtail 3 upgrade #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-test Feature/wagtail 3 upgrade fix test
louisbarron
approved these changes
Aug 22, 2022
aaronhaslett
requested changes
Aug 23, 2022
There was a problem hiding this comment.
This isn't done. You need to at least look at upgrade considerations on release notes and do everything it says. I checked the first three items in the 3.0 upgrade considerations and found the 2nd and 3rd were not done.
https://docs.wagtail.org/en/stable/releases/3.0.html
"Removal of special-purpose field panel types"
and
"BASE_URL setting renamed to WAGTAILADMIN_BASE_URL"
You gotta go through all those items in the upgrade considerations on the 3.0 and 2.16 release notes pages, and you need to check other stuff as well and skim through the minor versions for something relevant.
aaronhaslett
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.